Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UR-1170 Fix - User fields not saving #600

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

salimshrestha98
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR fixes a bug due to which the field values for registered users was not being saved.

How to test the changes in this Pull Request:

  1. Register a user using any user registration form.
  2. Verify if all the input values are being saved.
  3. Also verify that the values are being saved during edit profile action.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

UR-1170 Fix - User fields not saving

Copy link
Contributor

@MILAN88888 MILAN88888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@dipuchaudhary dipuchaudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@iamprazol iamprazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

@iamprazol iamprazol merged commit 82cc28c into master Sep 5, 2023
1 check passed
@iamprazol iamprazol deleted the UR-1170-fix-user-fields-not-saving branch September 5, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants